From 3ba75f130083092d43fa5126e6b9fc8fb638f532 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 19 Apr 2023 07:40:18 +0200 Subject: [PATCH] test: disable signal test under ASan and MSan (#3961) The signal_multiple_loops test is flaky when run under AddressSanitizer and MemorySanitizer. Sometimes thread creation fails, other times it simply times out. Fixes: https://github.com/libuv/libuv/issues/3956 --- test/test-signal-multiple-loops.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/test-signal-multiple-loops.c b/test/test-signal-multiple-loops.c index 483f59f20..de511fc06 100644 --- a/test/test-signal-multiple-loops.c +++ b/test/test-signal-multiple-loops.c @@ -208,9 +208,13 @@ TEST_IMPL(signal_multiple_loops) { #endif /* TODO(gengjiawen): Fix test on QEMU. */ #if defined(__QEMU__) - // See https://github.com/libuv/libuv/issues/2859 + /* See https://github.com/libuv/libuv/issues/2859 */ RETURN_SKIP("QEMU's signal emulation code is notoriously tricky"); #endif +#if defined(__ASAN__) || defined(__MSAN__) + /* See https://github.com/libuv/libuv/issues/3956 */ + RETURN_SKIP("Test is too slow to run under ASan or MSan"); +#endif #if defined(__TSAN__) /* ThreadSanitizer complains - likely legitimately - about data races * in uv__signal_compare() in src/unix/signal.c but that's pre-existing.