From 4887c09cf27167bb664b089b48d3ef9a5cb736cf Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Tue, 15 Jul 2025 23:01:38 +0200 Subject: [PATCH] win: fix -Wsign-compare warnings (#4835) --- src/win/udp.c | 7 +++++-- src/win/util.c | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/win/udp.c b/src/win/udp.c index e0873c2a8..f8aa2435c 100644 --- a/src/win/udp.c +++ b/src/win/udp.c @@ -1149,10 +1149,13 @@ int uv__udp_try_send2(uv_udp_t* handle, uv_buf_t* bufs[/*count*/], unsigned int nbufs[/*count*/], struct sockaddr* addrs[/*count*/]) { - unsigned int i; + int i; int r; - for (i = 0; i < count; i++) { + if (count > INT_MAX) + return UV_EINVAL; + + for (i = 0; i < (int) count; i++) { r = uv_udp_try_send(handle, bufs[i], nbufs[i], addrs[i]); if (r < 0) return i > 0 ? i : r; /* Error if first packet, else send count. */ diff --git a/src/win/util.c b/src/win/util.c index 8c2681fe8..a8c77103c 100644 --- a/src/win/util.c +++ b/src/win/util.c @@ -513,8 +513,8 @@ int uv_uptime(double* uptime) { unsigned int uv_available_parallelism(void) { DWORD_PTR procmask; DWORD_PTR sysmask; - int count; - int i; + unsigned count; + unsigned i; /* TODO(bnoordhuis) Use GetLogicalProcessorInformationEx() to support systems * with > 64 CPUs? See https://github.com/libuv/libuv/pull/3458