From be449a19794b1b56d85cbacee97697c1bdaef3e9 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 6 Sep 2019 10:07:13 +0200 Subject: [PATCH] build: make include/ public in CMakeLists.txt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: https://github.com/libuv/libuv/issues/1938 PR-URL: https://github.com/libuv/libuv/pull/2431 Reviewed-By: Colin Ihrig Reviewed-By: Saúl Ibarra Corretgé --- CMakeLists.txt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9ecaaeded..11a255801 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -345,13 +345,13 @@ endif() add_library(uv SHARED ${uv_sources}) target_compile_definitions(uv PRIVATE ${uv_defines} BUILDING_UV_SHARED=1) target_compile_options(uv PRIVATE ${uv_cflags}) -target_include_directories(uv PRIVATE include src) +target_include_directories(uv PUBLIC include PRIVATE src) target_link_libraries(uv ${uv_libraries}) add_library(uv_a STATIC ${uv_sources}) target_compile_definitions(uv_a PRIVATE ${uv_defines}) target_compile_options(uv_a PRIVATE ${uv_cflags}) -target_include_directories(uv_a PRIVATE include src) +target_include_directories(uv_a PUBLIC include PRIVATE src) target_link_libraries(uv_a ${uv_libraries}) option(libuv_buildtests "Build the unit tests when BUILD_TESTING is enabled." ON) @@ -363,7 +363,6 @@ if(BUILD_TESTING AND libuv_buildtests) target_compile_definitions(uv_run_tests PRIVATE ${uv_defines} USING_UV_SHARED=1) target_compile_options(uv_run_tests PRIVATE ${uv_cflags}) - target_include_directories(uv_run_tests PRIVATE include) target_link_libraries(uv_run_tests uv ${uv_test_libraries}) add_test(NAME uv_test COMMAND uv_run_tests @@ -371,7 +370,6 @@ if(BUILD_TESTING AND libuv_buildtests) add_executable(uv_run_tests_a ${uv_test_sources}) target_compile_definitions(uv_run_tests_a PRIVATE ${uv_defines}) target_compile_options(uv_run_tests_a PRIVATE ${uv_cflags}) - target_include_directories(uv_run_tests_a PRIVATE include) target_link_libraries(uv_run_tests_a uv_a ${uv_test_libraries}) add_test(NAME uv_test_a COMMAND uv_run_tests_a